Move file for DatasetPropertyNew component #1082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Dec 7, 2024
| @@ -93,6 +93,7 @@ const submit = () => { | |||
|
|
|||
| <i18n lang="json5"> | |||
| { | |||
| // @transifexKey component.DatasetOverviewNewProperty | |||
There was a problem hiding this comment.
Mostly filenames don't really matter, but the one place where they do have an effect is in Transifex. For Transifex, the string key is based on the filename, under the assumption that the filename will match the component name. (I couldn't think of a better way for our Transifex scripts to figure out the component name.) We don't want these messages to be retranslated, which is why I'm specifying @transifexKey here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about the
DatasetPropertyNewcomponent while looking at #1075 and noticed that the component file wasn't where I expected it to be. Based on its name, I'd expect its filename to be dataset/property/new.vue, but instead it's dataset/overview/new-property.vue. We're planning to remove the entity list overview page, so I think it's good timing to move this component out of the overview/ directory.What has been done to verify that this works as intended?
Tests continue to pass.
Why is this the best possible solution? Were any other approaches considered?
Another way to make the component name and the filename consistent would have been to change the component name to match the filename:
DatasetOverviewNewProperty. However, I prefer the current component name ofDatasetPropertyNew:*Newat the end matches other components, and we're soon going to be removing theDatasetOverviewcomponent.Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes